first cut - migrate settings marked with INTERNAL and adopt to advanced tag #1717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates internal configuration settings from the chat.advanced.* namespace to a simpler chat.* namespace, making them public/experimental settings accessible to users. The migration includes automatic configuration migration logic to transfer user values from old keys to new keys.
Key changes:
- Created a configuration migration registry system to handle automatic migration of setting values
- Moved 40+ settings from
chat.advanced.*tochat.*namespace and changed them from internal-only to public settings - Updated tests to reflect new setting IDs and public visibility
- Added localization strings and package.json schema entries for newly public settings
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/platform/configuration/common/configurationService.ts | Adds configuration migration infrastructure and updates 40+ setting definitions to use new namespace with migration |
| src/platform/configuration/test/common/configurationService.spec.ts | Updates test assertions to verify new setting IDs and public visibility |
| src/extension/configuration/vscode-node/configurationMigration.ts | Moves migration types to platform layer, imports them instead |
| package.nls.json | Adds localization strings for newly public settings |
| package.json | Adds schema definitions for newly public experimental settings |
ulugbekna
previously approved these changes
Oct 31, 2025
- reading config value - reading experiment - listening to changes
ulugbekna
reviewed
Nov 13, 2025
Contributor
ulugbekna
left a comment
ulugbekna
left a comment
There was a problem hiding this comment.
Backward compatibility with exp makes sense to me. Posted some other thoughts I have
bpasero
previously approved these changes
Nov 14, 2025
alexdima
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.